New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve import functionality #514

Open

Danble wants to merge 10 commits into main from improve-import-functionality

+212 −187

Collaborator

Danble commented Nov 28, 2024 •

edited

Loading

No description provided.

Danble added 4 commits

November 28, 2024 14:04


          allow missing media files witouth breaking

b8dded3


          fix speakers import

eeb6737


          fix file name


          fix vernacular example sentences in example-v4

b3a17f1

vercel bot commented Nov 28, 2024 •

edited

Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
living-dictionaries	✅ Ready (Inspect)	Visit Preview	Dec 4, 2024 4:46am

Danble added 3 commits

November 29, 2024 12:43


          import senses only when they exist

11f74ef


          import first row when it is not a helper row

d334d7e


          allow import entries without any glosses (only available for first se…

6f1a24b

…nse)

vercel bot deployed to Preview

November 29, 2024 20:03

View deployment


          Merge branch 'main' of github.com:livingtongues/living-dictionaries i…

7741b99

…nto improve-import-functionality

vercel bot deployed to Preview

December 2, 2024 23:15

View deployment

Danble requested a review from jacob-8

December 3, 2024 00:39

Danble marked this pull request as ready for review

December 3, 2024 00:40


          small change

609013c

vercel bot deployed to Preview

December 3, 2024 16:57

View deployment


          make tests sense ordering fixed, handle media errors better, handle m…

df2f636

…ultiple photo uploads for 1 sense

github-actions bot reviewed

View reviewed changes

github-actions bot left a comment

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 48 in df2f636

"es": "día",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 52 in df2f636

"n",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 83 in df2f636

"default": "kꞌajkꞌal",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 86 in df2f636

"default": "14/dic./2019",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 87 in df2f636

},

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 113 in df2f636

"es": "calor",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 117 in df2f636

"n",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 118 in df2f636

],

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 142 in df2f636

"default": "kꞌajkꞌ",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 145 in df2f636

"default": "23/sep./2023",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 146 in df2f636

},

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 174 in df2f636

],

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 178 in df2f636

"es": "fiebre",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 182 in df2f636

"n",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 185 in df2f636

"11111111-1111-1111-1111-111111100065",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 186 in df2f636

],

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 190 in df2f636

"es": "caliente",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 194 in df2f636

"adj",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 197 in df2f636

"11111111-1111-1111-1111-111111100067",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 198 in df2f636

],

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 199 in df2f636

},

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 202 in df2f636

"updated_at": "2024-03-08T00:44:04.702+00:00",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 213 in df2f636

"default": "jun",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 216 in df2f636

"default": "26/sep./2023",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 217 in df2f636

},

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 222 in df2f636

"es": "libro",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 226 in df2f636

"n",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 229 in df2f636

"11111111-1111-1111-1111-111111100071",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 230 in df2f636

],

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 234 in df2f636

"es": "cuaderno",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 238 in df2f636

"n",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 241 in df2f636

"11111111-1111-1111-1111-111111100073",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 242 in df2f636

],

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 246 in df2f636

"es": "documento",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 250 in df2f636

"n",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 253 in df2f636

"11111111-1111-1111-1111-111111100075",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 254 in df2f636

],

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 258 in df2f636

"es": "papel",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 262 in df2f636

"n",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 265 in df2f636

"11111111-1111-1111-1111-111111100077",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 266 in df2f636

],

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 267 in df2f636

},

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 270 in df2f636

"updated_at": "2024-03-08T00:44:04.717+00:00",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 281 in df2f636

"default": "jeꞌel",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 284 in df2f636

"default": "08/abr./2019",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 285 in df2f636

},

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 290 in df2f636

"es": "abierto",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 294 in df2f636

"adj",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 297 in df2f636

"11111111-1111-1111-1111-111111100081",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 300 in df2f636

"default": "makal",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 301 in df2f636

},

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 305 in df2f636

"es": "abrir",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 309 in df2f636

"11111111-1111-1111-1111-111111100083",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 310 in df2f636

],

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 311 in df2f636

},

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 314 in df2f636

"updated_at": "2024-03-08T00:44:04.726+00:00",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 315 in df2f636

},

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 325 in df2f636

"default": "Jaꞌnix lek-a lokꞌix tel kꞌaal",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 329 in df2f636

"es": "Que bueno, ya salió el sol",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 332 in df2f636

"updated_by": "be43b1dd-6c64-494d-b5da-10d70c384433",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 341 in df2f636

"default": "Ay bayal skꞌaal te chꞌin x-Ixchele",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 345 in df2f636

"es": "Mi hijita Ixchel tiene mucha fiebre",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 348 in df2f636

"updated_by": "be43b1dd-6c64-494d-b5da-10d70c384433",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 357 in df2f636

"default": "Bajtix kaal mamtik, yorailix ich lewa",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 361 in df2f636

    
           "es": "Ya transcurrió el día mi estimado señor, es momento de tomar un descanso",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 364 in df2f636

"updated_by": "be43b1dd-6c64-494d-b5da-10d70c384433",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 373 in df2f636

"default": "Toyol kꞌaal ya jkaꞌiy",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 377 in df2f636

"es": "Siento mucho calor",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 380 in df2f636

"updated_by": "be43b1dd-6c64-494d-b5da-10d70c384433",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 389 in df2f636

"default": "Tilix kuꞌun-i kꞌajkꞌi",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 393 in df2f636

"es": "Ya hice el fuego",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 396 in df2f636

"updated_by": "be43b1dd-6c64-494d-b5da-10d70c384433",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 405 in df2f636

"default": "Lom kꞌajkꞌ te mamal jkaxlane",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 409 in df2f636

"es": "El mestizo es muy bravo",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 412 in df2f636

"updated_by": "be43b1dd-6c64-494d-b5da-10d70c384433",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 421 in df2f636

"default": "Tsakbil ta kꞌajkꞌ te alale",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 425 in df2f636

"es": "El bebé tiene mucha fiebre",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 428 in df2f636

"updated_by": "be43b1dd-6c64-494d-b5da-10d70c384433",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 437 in df2f636

"default": "El café está caliente, tómalo despacio",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 441 in df2f636

"es": "Kꞌajkꞌ te kajpele, kꞌume xa awuchꞌ",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 444 in df2f636

"updated_by": "be43b1dd-6c64-494d-b5da-10d70c384433",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 453 in df2f636

"default": "¿Beluk apas? - Yakalon ta skꞌoponel jun",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 457 in df2f636

"es": "¿Qué haces? - Estoy leyendo un libro",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 460 in df2f636

"updated_by": "be43b1dd-6c64-494d-b5da-10d70c384433",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 469 in df2f636

"default": "La jta ta kitsel te june",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 473 in df2f636

"es": "Alcancé a rayar mi cuaderno",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 476 in df2f636

"updated_by": "be43b1dd-6c64-494d-b5da-10d70c384433",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 485 in df2f636

"default": "Maꞌme xa awochꞌ te ajune",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 489 in df2f636

"es": "No vayas a arrugar tu documento",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 492 in df2f636

"updated_by": "be43b1dd-6c64-494d-b5da-10d70c384433",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 501 in df2f636

"default": "Zoe rompió el papel",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 505 in df2f636

"es": "La schꞌiꞌ jun te Zoe",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 508 in df2f636

"updated_by": "be43b1dd-6c64-494d-b5da-10d70c384433",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 517 in df2f636

"default": "Jeꞌel jilel stiꞌ jna",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 521 in df2f636

"es": "La puerta de mi casa quedó abierta",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 524 in df2f636

"updated_by": "be43b1dd-6c64-494d-b5da-10d70c384433",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 533 in df2f636

"default": "Jeꞌa tel tebuk i tiꞌnai ay bayal kꞌaal",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 537 in df2f636

"es": "Abre un poco la puerta, hace mucho calor",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 540 in df2f636

"updated_by": "be43b1dd-6c64-494d-b5da-10d70c384433",

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 541 in df2f636

},

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 542 in df2f636

],

🚫 [eslint] <style/eol-last> _{reported by reviewdog 🐶}
Newline required at end of file but not found.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 543 in df2f636

}

packages/scripts/import/import-data.snap.json

		@@ -16,18 +16,6 @@
		},

github-actions bot Dec 4, 2024

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

Suggested change

packages/scripts/import/import-data.snap.json

-                        "sentence_ids": [
-                          "11111111-1111-1111-1111-111111100051",
-                        ],
-                      },
                       {
                         "glosses": {
                           "es": "sol",

github-actions bot Dec 4, 2024

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

Suggested change

      
                        "es": "sol",
          
                        "es": "sol"

packages/scripts/import/import-data.snap.json

		@@ -67,13 +55,25 @@
		"11111111-1111-1111-1111-111111100049",

github-actions bot Dec 4, 2024

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

Suggested change

      
                        "11111111-1111-1111-1111-111111100049",
          
                        "11111111-1111-1111-1111-111111100049"

packages/scripts/import/import-data.snap.json

		@@ -67,13 +55,25 @@
		"11111111-1111-1111-1111-111111100049",
		],

github-actions bot Dec 4, 2024

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

Suggested change

packages/scripts/import/import-data.snap.json

@@ @@ -67,13 +55,25 @@ @@
                           "11111111-1111-1111-1111-111111100049",
                         ],
                       },
+                      {
+                        "glosses": {
+                          "es": "calor",

github-actions bot Dec 4, 2024

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

Suggested change

      
                        "es": "calor",
          
                        "es": "calor"

packages/scripts/import/import-data.snap.json

                         ],
+                        "variant": {
+                          "default": "kꞌahkꞌ",

github-actions bot Dec 4, 2024

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

Suggested change

      
                        "default": "kꞌahkꞌ",
          
                        "default": "kꞌahkꞌ"

packages/scripts/import/import-data.snap.json

                         ],
+                        "variant": {
+                          "default": "kꞌahkꞌ",
+                        },

github-actions bot Dec 4, 2024

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

Suggested change

packages/scripts/import/import-data.snap.json

                       },
                       {
                         "glosses": {
-                          "es": "caliente",
+                          "es": "bravo",

github-actions bot Dec 4, 2024

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

Suggested change

      
                        "es": "bravo",
          
                        "es": "bravo"

packages/scripts/import/import-data.snap.json

                         },
-                        "id": "11111111-1111-1111-1111-111111100066",
+                        "id": "11111111-1111-1111-1111-111111100062",
                         "parts_of_speech": [
                           "adj",

github-actions bot Dec 4, 2024

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

Suggested change

packages/scripts/import/import-data.snap.json

                         "parts_of_speech": [
                           "adj",
                         ],
                         "sentence_ids": [
-                          "11111111-1111-1111-1111-111111100067",
+                          "11111111-1111-1111-1111-111111100063",

github-actions bot Dec 4, 2024

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

Suggested change

      
                        "11111111-1111-1111-1111-111111100063",
          
                        "11111111-1111-1111-1111-111111100063"

jacob-8 approved these changes

View reviewed changes

Collaborator

jacob-8 left a comment

Code is good to merge - I made some additional changes, please read over them before merging.

github-actions bot reviewed

View reviewed changes

packages/scripts/import/import-data.snap.json

github-actions bot Dec 4, 2024

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 12 in df2f636

"default": "kꞌaal",

github-actions bot reviewed

View reviewed changes

packages/scripts/import/import-data.snap.json

github-actions bot Dec 4, 2024

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 15 in df2f636

"default": "26/dic./2020",

github-actions bot reviewed

View reviewed changes

packages/scripts/import/import-data.snap.json

github-actions bot Dec 4, 2024

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 25 in df2f636

"n",

github-actions bot reviewed

View reviewed changes

packages/scripts/import/import-data.snap.json

github-actions bot Dec 4, 2024

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 28 in df2f636

"11111111-1111-1111-1111-111111100045",

github-actions bot reviewed

View reviewed changes

packages/scripts/import/import-data.snap.json

github-actions bot Dec 4, 2024

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 31 in df2f636

"default": "kꞌahkꞌal",

github-actions bot reviewed

View reviewed changes

packages/scripts/import/import-data.snap.json

github-actions bot Dec 4, 2024

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 32 in df2f636

},

github-actions bot reviewed

View reviewed changes

packages/scripts/import/import-data.snap.json

github-actions bot Dec 4, 2024

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 36 in df2f636

"es": "fiebre",

github-actions bot reviewed

View reviewed changes

packages/scripts/import/import-data.snap.json

github-actions bot Dec 4, 2024

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 40 in df2f636

"n",

github-actions bot reviewed

View reviewed changes

packages/scripts/import/import-data.snap.json

github-actions bot Dec 4, 2024

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 43 in df2f636

"11111111-1111-1111-1111-111111100047",

github-actions bot reviewed

View reviewed changes

packages/scripts/import/import-data.snap.json

github-actions bot Dec 4, 2024

🚫 [eslint] <jsonc/comma-dangle> _{reported by reviewdog 🐶}
Unexpected trailing comma.

living-dictionaries/packages/scripts/import/import-data.snap.json

Line 44 in df2f636

],

vercel bot deployed to Preview

December 4, 2024 04:46

View deployment

github-actions bot commented Dec 4, 2024

⚡️Lighthouse report

Results for https://living-dictionaries-80o67l23w-polylingual-development.vercel.app/ (see detailed report)

Category	Score
🔴 Performance	15
🟢 Accessibility	90
🟢 Best practices	100
🟢 SEO	96
🟢 PWA	90

Results for https://living-dictionaries-80o67l23w-polylingual-development.vercel.app/achi/entries (see detailed report)

Category	Score
🔴 Performance	46
🟢 Accessibility	90
🟢 Best practices	92
🟢 SEO	97
🟢 PWA	90

Results for https://living-dictionaries-80o67l23w-polylingual-development.vercel.app/jaRhn6MAZim4Blvr1iEv/entry/yt9ja7ymh9xgba5i (see detailed report)

Category	Score
🔴 Performance	40
🟠 Accessibility	89
🟢 Best practices	92
🟢 SEO	100
🟢 PWA	90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet